Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DBT image to fix tests for partnership_asset_prices model #438

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Update DBT image to fix tests for partnership_asset_prices model #438

merged 1 commit into from
Jul 18, 2024

Conversation

amishas157
Copy link
Contributor

@amishas157 amishas157 commented Jul 18, 2024 •
edited
Loading

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with the jira ticket associated with the PR.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated the README with the added features, breaking changes, new instructions on how to use the repository.

What

Tests for partnership_asset_prices model have been failing. This PR updates DBT image. The new DBT image contains fixed tests.

Why

To unblock DBT build process

Known limitations

None

@amishas157 amishas157 marked this pull request as ready for review July 18, 2024 19:19
@amishas157 amishas157 requested a review from a team as a code owner July 18, 2024 19:19
@amishas157 amishas157 merged commit 04141cf into master Jul 18, 2024
4 checks passed
amishas157 added a commit that referenced this pull request Jul 18, 2024
@github-actions @amishas157
Update DBT image (#438) (#439)
674ddae 
Co-authored-by: Amisha Singla <[email protected]>
@amishas157 amishas157 deleted the fix-dbt-tests branch July 26, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harsha-stellar-data harsha-stellar-data harsha-stellar-data approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amishas157 @harsha-stellar-data